Peft deepspeed resume #1227
Merged
Peft deepspeed resume #1227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
|
Looks like it does the same as huggingface/transformers#28746 |
|
Thanks for that. I'll wait for that to get merged 🤞. Hard to keep track.of everything upstream. |
|
Once this is fixed upstream, we can remove the monkeypatch from this PR, but I think we still need to handle the lora_model_dir part. |
|
@manishiitg this was fixed upstream, can you confirm if the upstream fix works for you? |
winglian
force-pushed
the
peft-deepspeed-resume
branch
from
5594554 to
839637c
Compare
|
looks like we need to handle some changes from this PR too huggingface/transformers#26610 |
djsaunde
pushed a commit
that referenced
this pull request
Dec 17, 2024
* import deepspeed integration * monkeypatch peft adapater with deepspeed for resume from checkpoint * fix patch * fix patches attempt 2 * make sure to set lora_model_dir * skip pylint for deepspeed.utils * pick up upstream fix in transformers * remove monkeypatch for deepspeed/peft fix * no need to set the lora_model_dir on resume * unset load_in_*bit when using quant config * guard before del * better handling of load_in* kwargs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1134