More fixes for issues caught by fuzzer #935
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fuzzer caught another large malloc. This is caused by lack of boundary check in Ap4OdheAtom causing underflow.
Earlier boundary checks were insufficient to prevent certain potential payloads. This adds more boundary checks to prevent underflow of remains. I have also remove the usage of GetHeaderSize in constructor as it is a virtual method.
Fuzzer caught another large malloc. This is caused by lack of boundary check in Ap4SbgpAtom causing underflow.
Fuzzer caught another large malloc in Ap4SbgpAtom. It is caused by overflow in boundary check
The lack of boundary checks in Ap4ContainerAtom leads to an underflow in size which then leads to existing validation checks to fail and hence allow large malloc.
Same problem as before, underflow of bytes_available results in some potential attack
barbibulle
approved these changes
Apr 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fuzzer caught some issues and these two commits have the fixes. The issues are in the space of large malloc that is the result of underflow (due to incorrect boundary checks).