Skip to content

Commit

Permalink
Prevent overflow in boundary check for Ap4SbgpAtom
Browse files Browse the repository at this point in the history
Fuzzer caught another large malloc in Ap4SbgpAtom. It is caused by overflow
in boundary check
  • Loading branch information
roticv committed Mar 27, 2024
1 parent f9f6b22 commit 8806fe2
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion Source/C++/Core/Ap4SbgpAtom.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ AP4_SbgpAtom::AP4_SbgpAtom(AP4_UI32 size,
AP4_Result result = stream.ReadUI32(entry_count);
if (AP4_FAILED(result)) return;
remains -= 4;
if (remains < entry_count*8) {
if (remains < (AP4_UI64)entry_count*8) {
return;
}
m_Entries.SetItemCount(entry_count);
Expand Down

0 comments on commit 8806fe2

Please sign in to comment.