disallow unassigned witness

axiom-crypto · May 10, 2024 · 626c6b2 · 626c6b2
1 parent 0350dd7
commit 626c6b2
Showing 1 changed file with 1 addition and 2 deletions.
diff --git a/halo2-ecc/src/ecc/hash_to_curve.rs b/halo2-ecc/src/ecc/hash_to_curve.rs
@@ -392,9 +392,8 @@ impl ExpandMessageChip for ExpandMsgXmd {
         let assigned_msg = msg
             .map(|cell| match cell {
                 QuantumCell::Existing(v) => v,
-                QuantumCell::Witness(v) => thread_pool.main().load_witness(v),
                 QuantumCell::Constant(v) => thread_pool.main().load_constant(v),
-                _ => unreachable!(),
+                _ => panic!("passing unassigned witness to this function is insecure"),
             })
             .collect_vec();