Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: trim unix:// prefix for address flag #934

Merged
merged 1 commit into from
Nov 15, 2023

Conversation

tuananh
Copy link
Contributor

@tuananh tuananh commented Nov 11, 2023

Issue #, if available:
Fixes: #880

Description of changes:
Trim the unix:// prefix in address if presented so this now works

image

Previously, it would fail with

image

Testing performed:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@tuananh tuananh requested a review from a team as a code owner November 11, 2023 00:01
Copy link
Contributor

@austinvazquez austinvazquez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM. Thanks for the contribution!

@austinvazquez austinvazquez merged commit 3aaee24 into awslabs:main Nov 15, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] soci cli fails if containerd address starts with "unix://"
4 participants