Add go-fuse logger #864
Merged
Add go-fuse logger #864
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soci-snapshotter-gprc overrides the default logger to be a logrus logger with debug as the write level. If the snapshotter is invoked with `--log-level debug`, then logs from e.g. `log.PrinLn` are visibile. go-fuse uses this logging method to output a complete transaction of fuse operations keeping track of each request/response with a unique id. The ID is only unique within a single server, so trying to parse the logs is ambiguous since you don't know which server a response corresponds to. go-fuse recently added support for per-server loggers. This change uses that functionality to add the layer digest to the logs from each fuse server so request/response pairs can be unambiguously matched. It also changes the log level of go-fuse logs to trace since there really is no debug reason for enabling them. Signed-off-by: Kern Walster <[email protected]>
turan18
approved these changes
Oct 9, 2023
sondavidb
approved these changes
Oct 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
soci-snapshotter-gprc overrides the default logger to be a logrus logger with debug as the write level. If the snapshotter is invoked with
--log-level debug, then logs from e.g.log.PrinLnare visibile.go-fuse uses this logging method to output a complete transaction of fuse operations keeping track of each request/response with a unique id. The ID is only unique within a single server, so trying to parse the logs is ambiguous since you don't know which server a response corresponds to.
go-fuse recently added support for per-server loggers. This change uses that functionality to add the layer digest to the logs from each fuse server so request/response pairs can be unambiguously matched.
It also changes the log level of go-fuse logs to trace since there really is no debug reason for enabling them.
Testing performed:
make check && make test && make integrationI also manually ran the snapshotter with
--log-level debugto make sure there are no go-fuse logs and then again with--log-level traceto see the logs.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.