Fix integrations tests with cgroupv2 #850
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With cgroupv2, dind doesn't work out of the box because the inner docker process is in the (containerized) root cgroup so it can't create the inner container's cgroups because doing so would make the inner docker a process on an interior cgroup node. cgroupv2 only allows processes on the leaf nodes. The solution is to move docker to a child cgroup (called init) so that the container can exist as a sibling. Signed-off-by: Kern Walster <[email protected]>
sondavidb
approved these changes
Oct 2, 2023
turan18
reviewed
Oct 2, 2023
turan18
approved these changes
Oct 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
closes #735
Description of changes:
With cgroupv2, dind doesn't work out of the box because the inner docker process is in the (containerized) root cgroup so it can't create the inner container's cgroups because doing so would make the inner docker a process on an interior cgroup node. cgroupv2 only allows processes on the leaf nodes.
The solution is to move docker to a child cgroup (called init) so that the container can exist as a sibling.
Testing performed:
make check && make integrationon an al2023 instance which uses cgroupv2.Before this change the tests failed with:
after this change, the tests pass
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.