Fix regression in metrics startup order #1440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
go
timj-hh
approved these changes
Dec 19, 2024
Before this change, if the metrics socket was a unix socket, SOCI would not create the parent dir before trying to bind. This exposed an implicit dependency on bind order if you tried to put the metrics address next to the main socket which we broke when we introduced systemd socket activation. This change ensures that we create the parent dir before binding the metrics socket. Signed-off-by: Kern Walster <[email protected]>
Kern--
force-pushed
the
fix-metrics-socket
branch
from
6086ab6 to
e1af74e
Compare
timj-hh
approved these changes
Dec 20, 2024
coderbirju
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
N/A
Description of changes:
Before this change, if the metrics socket was a unix socket, SOCI would
not create the parent dir before trying to bind. This exposed an
implicit dependency on bind order if you tried to put the metrics
address next to the main socket which we broke when we introduced
systemd socket activation.
This change ensures that we create the parent dir before binding the
metrics socket.
Testing performed:
GO_TEST_FLAGS='-run TestSnapshotterStartup' make integrationI verified that the updated test failed before the snapshotter change and succeeds after.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.