Add EKS docs to automated version updating #1404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: David Son <[email protected]>
github-actions
bot
added
the
github_actions
pendo324
approved these changes
Nov 4, 2024
coderbirju
approved these changes
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
docs/eks.mdincludes the latest SOCI version in its contents so we should update that too. Looking at this we should probably clean up some of the shellscript directives used here in general but I'd rather do that in a separate PR since the main point here is to add this to the automation.Might be worth thinking about if we want to simply have the script check the entirety of docs for this string instead.
Testing performed:
Ran
scripts/update-getting-started-guide-version.sh --verbose v0.0.0and confirmed the proper changes were made.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.