Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update toolchain min version to Go 1.22 #1353

Merged
merged 1 commit into from
Aug 27, 2024

Conversation

austinvazquez
Copy link
Contributor

@austinvazquez austinvazquez commented Aug 27, 2024

Issue #, if available:
#1352 dependency update is updating the Go min version, but should be handled separately for completeness.

Description of changes:
This change updates Go in CI and documentation to Go 1.22 (Go 1.21 is now EOL with the Go 1.23 release)

Testing performed:
CI verification is enough

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@austinvazquez austinvazquez marked this pull request as ready for review August 27, 2024 15:22
@austinvazquez austinvazquez requested a review from a team as a code owner August 27, 2024 15:22
Copy link
Contributor

@sondavidb sondavidb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, can we mention in the PR or commit message this is due to 1.21 being deprecated?

@austinvazquez
Copy link
Contributor Author

@sondavidb, I updated the description to include it.

@austinvazquez austinvazquez merged commit e8636bc into awslabs:main Aug 27, 2024
20 checks passed
@austinvazquez austinvazquez deleted the update-golang branch August 27, 2024 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants