Add codebuild integrations for our workflows #1254
Conversation
Signed-off-by: Arjun Raja Yogidas <[email protected]>
coderbirju
force-pushed
the
codebuild-test-integration-failures
branch
from
d7852e8 to
254485a
Compare
There was a problem hiding this comment.
IMO the default should be to run on GH Actions runners, and only run tests on CodeBuild if we have a reason.
With that reasoning, I think we should only run benchmarking (for consistency) + integration tests (for ARM support) on CodeBuild. Perhaps unit tests as well, just so we're running all of our SOCI-related tests in a consistent environment. But that's just my thoughts, feel free to disagree.
austinvazquez
added
the
github_actions
coderbirju
force-pushed
the
codebuild-test-integration-failures
branch
6 times, most recently
from
ffa13d2 to
3eb8c7e
Compare
| @@ -17,7 +17,7 @@ env: | |||
|
|
|||
| jobs: | |||
| benchmark: | |||
| runs-on: ubuntu-20.04 | |||
| runs-on: ${{ 'github.event.pull_request.head.repo.fork ' && 'ubuntu-22.04' || 'codebuild-soci-visualization-workflow-${{ github.run_id }}-${{ github.run_attempt }}-ubuntu-7.0-xlarge' }} | |||
There was a problem hiding this comment.
Based on the tests run in this PR it seems this will just always run 22.04.
Also, I assume we're switching to 22.04 because that's what CodeBuild uses?
There was a problem hiding this comment.
Updated the workflow, there is not really a simpler way to add conditions to the runner type. One of those times where WET code makes more sense to reduce complicated conditions.
coderbirju
force-pushed
the
codebuild-test-integration-failures
branch
8 times, most recently
from
2afb605 to
10e26ba
Compare
Signed-off-by: Arjun Raja Yogidas <[email protected]>
coderbirju
force-pushed
the
codebuild-test-integration-failures
branch
from
10e26ba to
5032fbc
Compare
coderbirju
force-pushed
the
codebuild-test-integration-failures
branch
from
9fe26cc to
459324d
Compare
coderbirju
force-pushed
the
codebuild-test-integration-failures
branch
from
459324d to
3ba1ee0
Compare
Requires #1255
This PR adds the capability to run our workloads on codebuild instances. This allows us to manage the instance size/performance in a consistent manner. It also allows the use of ARM runners which will enable us to automate the release process for arm binaries in the future.
Running the Integration tests on both GH runners and codebuild to make sure we are able to identify any potential kernel specific issues.Don't see any compelling reasons to run the integration tests on both github and codebuild and have kept the fork runs exclusively on github. If there are any kernel issues then we will see it when we make updates and run these tests in the fork.
We now use Ubuntu 22.04 as the underlying OS for all our workloads
Issue #, if available:
Description of changes:
Testing performed:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.