Add go license check to CI #1249
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
austinvazquez
force-pushed
the
add-go-license-check
branch
2 times, most recently
from
8ab4583 to
9656b08
Compare
This change is a raw import of the third party license validation code from https://github.com/awslabs/amazon-ecr-credential-helper/tree/6bae25fb558e48ec1359a54dc58d163b53f9cd0d Signed-off-by: Austin Vazquez <[email protected]>
austinvazquez
force-pushed
the
add-go-license-check
branch
from
9656b08 to
7b3f689
Compare
Signed-off-by: Austin Vazquez <[email protected]>
austinvazquez
force-pushed
the
add-go-license-check
branch
from
7b3f689 to
d392c73
Compare
pendo324
approved these changes
May 30, 2024
sondavidb
reviewed
May 30, 2024
| @@ -0,0 +1,41 @@ | |||
| #!/usr/bin/env bash | |||
|
|
|||
| # Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved. | |||
There was a problem hiding this comment.
Should this be consistent with our other SOCI scripts? i.e. should the copyright be to Soci Snapshotter Authors instead of Amazon?
Otherwise LGTM
austinvazquez
added
the
github_actions
|
Superseded by #1328 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
The SOCI project intends to follow CNCF best practices, but currently has no mechanism for enforcing license checks of 3rd party dependencies. As a maintainer, it would be helpful to validate in CI that each contribution is following the guidance set forth by Amazon and CNCF with respect to usage of open source in the project.
Description of changes:
This change imports licenses check mechanism from the Amazon ECR credential helper project to validate usage of 3rd party dependencies is in alignment with Amazon and CNCF Open Source License usage best practices.
Testing performed:
Check is successful in CI
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.