Regenerate changed flatbuffer definitions #1212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Change LGTM. While you have the hood open on this, can you also add a check to |
sondavidb
force-pushed
the
properly-check-for-changes-flatc
branch
6 times, most recently
from
31ffee3 to
23ed299
Compare
austinvazquez
previously approved these changes
May 3, 2024
Kern--
previously approved these changes
May 10, 2024
Signed-off-by: David Son <[email protected]>
sondavidb
force-pushed
the
properly-check-for-changes-flatc
branch
from
23ed299 to
e455c86
Compare
austinvazquez
approved these changes
May 11, 2024
Kern--
approved these changes
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Fixes #491
Description of changes:
Previously, any changes to the flatbuffer definitions (
ztoc/fbs/ztoc.fbsandztoc/compression/fbs/zinfo.fbs) would not automatically regenerate the flatbuffer definitions. This change allows the Makefile to track these changes, and the refactors to the flatc target to do so.. Additionally, I added flatc as a prereq to soci-snapshotter-grpc, so it should automatically regenerate if any changes are present whenmakeis run.Testing performed:
makeafter changing flatbuffer definition and confirmed that they were being regenerated.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.