Add Makefile target to cleanup testing artifacts #1205
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Fixes #1204
Description of changes:
Our integration testing suite can leave artifacts if it is prematurely quit. When run multiple times, this can lead to many artifacts left over, taking up unnecessary disk space, CPU usage, and Docker networks. This change uses a common base container name for all of our testing containers, and allows
As a compliment to this, I noticed that our Dockerfile, when manually built, would result in an improperly-tagged image. The first commit just moves the registry pull to its own line so that it can be properly tagged when built manually. Not necessary at all, and can remove from this commit if needed, I just thought it would be nice to have :p
Testing performed:
Ran a test (e.g.
GO_TEST_FLAGS='-run TestNetworkRetry -count 1' make integration
), cancelled it after it started running, and checked that appropriate artifacts were cleaned.Testing workflow (redacted/truncated data denoted with "..."
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.