Add release workflow testing #1186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: David Son <[email protected]>
Kern--
approved these changes
Apr 19, 2024
austinvazquez
approved these changes
Apr 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Followup to release of v0.6.0
Description of changes:
We don't have testing for any changes we make that could affect our release workflow. This change adds testing to avoid issues such as the one faced in v0.6.0 where our automated release failed due to a script change that was untested.
Testing performed:
Created PR against my local branch and ensured CI was green: https://github.com/sondavidb/soci-snapshotter/actions/runs/8713640295?pr=12
Also pushed tag after pushing a dummy THIRD_PARTY_LICENSES commit and ensured CI was green: https://github.com/sondavidb/soci-snapshotter/actions/runs/8713610525
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.