Skip to content

Commit

Permalink
Update scripts with minor changes
Browse files Browse the repository at this point in the history
This changeset adds consistent naming to shell scripts, adds copyrights
to benchmark scripts, and changes shebangs to env bash to work in
environments when bash is not under `/bin/`.

Signed-off-by: Austin Vazquez <[email protected]>
  • Loading branch information
austinvazquez committed Oct 23, 2023
1 parent f72ea9c commit 19a7521
Show file tree
Hide file tree
Showing 13 changed files with 43 additions and 15 deletions.
6 changes: 3 additions & 3 deletions .github/workflows/benchmark_visualization.yml
Original file line number Diff line number Diff line change
Expand Up @@ -46,10 +46,10 @@ jobs:
path: ${{github.workspace}}
- name: Make temporary folder
run: mkdir ${{github.workspace}}/current
- name: Change permission of visualization_data_converter.sh
run: chmod +x ${{github.workspace}}/scripts/visualization_data_converter.sh
- name: Change permission of visualization-data-converter.sh
run: chmod +x ${{github.workspace}}/scripts/visualization-data-converter.sh
- name: Convert benchmark result to visualization data
run: ${{github.workspace}}/scripts/visualization_data_converter.sh ${{github.workspace}}/results.json ${{github.workspace}}/current
run: ${{github.workspace}}/scripts/visualization-data-converter.sh ${{github.workspace}}/results.json ${{github.workspace}}/current
- name: Build matrix of filepaths
id: set-matrix
# Create a JSON array with the file paths and store it in the 'files' output
Expand Down
2 changes: 1 addition & 1 deletion scripts/add-ltag.sh
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
#!/bin/bash
#!/usr/bin/env bash

# Copyright The containerd Authors.

Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
#!/bin/bash
#!/usr/bin/env bash

# Copyright The containerd Authors.

Expand Down
2 changes: 1 addition & 1 deletion scripts/bump-deps.sh
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
#!/bin/bash
#!/usr/bin/env bash

# Copyright The containerd Authors.

Expand Down
2 changes: 1 addition & 1 deletion scripts/check-all.sh
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
#!/bin/bash
#!/usr/bin/env bash

# Copyright The containerd Authors.

Expand Down
2 changes: 1 addition & 1 deletion scripts/check-dco.sh
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
#!/bin/bash
#!/usr/bin/env bash

# Copyright The containerd Authors.

Expand Down
2 changes: 1 addition & 1 deletion scripts/check-flatc.sh
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
#!/bin/bash
#!/usr/bin/env bash

# Copyright The containerd Authors.

Expand Down
2 changes: 1 addition & 1 deletion scripts/check-lint.sh
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
#!/bin/bash
#!/usr/bin/env bash

# Copyright The containerd Authors.

Expand Down
2 changes: 1 addition & 1 deletion scripts/check-ltag.sh
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
#!/bin/bash
#!/usr/bin/env bash

# Copyright The containerd Authors.

Expand Down
16 changes: 15 additions & 1 deletion scripts/check_regression.sh → scripts/check-regression.sh
Original file line number Diff line number Diff line change
@@ -1,4 +1,18 @@
#!/bin/bash
#!/usr/bin/env bash

# Copyright The Soci Snapshotter Authors.

# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at

# http://www.apache.org/licenses/LICENSE-2.0

# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.

set -eu -o pipefail

Expand Down
2 changes: 1 addition & 1 deletion scripts/install-check-tools.sh
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
#!/bin/bash
#!/usr/bin/env bash

# Copyright The containerd Authors.

Expand Down
2 changes: 1 addition & 1 deletion scripts/install-dep.sh
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
#!/bin/bash
#!/usr/bin/env bash

# Copyright The containerd Authors.

Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,18 @@
#!/bin/bash
#!/usr/bin/env bash

# Copyright The Soci Snapshotter Authors.

# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at

# http://www.apache.org/licenses/LICENSE-2.0

# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.

set -eux -o pipefail

Expand Down

0 comments on commit 19a7521

Please sign in to comment.