Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Simplify & fix Swift 6 issues in protocol test manifest #1855

Merged
merged 3 commits into from
Jan 7, 2025

Conversation

jbelkins
Copy link
Contributor

@jbelkins jbelkins commented Jan 6, 2025

Description of changes

  • Protocol test package manifest no longer raises warnings in Swift 6
  • Logic for running against main & stable AWS SDK is removed. Protocol tests are always run against local aws-sdk-swift & smithy-swift.
  • The direct dependency on aws-crt-swift is removed, as it is not directly referenced. CRT is still a transitive dependency.

New/existing dependencies impact assessment, if applicable

No new dependencies were added to this change.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jbelkins jbelkins marked this pull request as ready for review January 6, 2025 23:55
@jbelkins jbelkins requested review from sichanyoo and dayaffe January 6, 2025 23:55
Copy link
Contributor

@sichanyoo sichanyoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup ! LGTM

@jbelkins jbelkins merged commit 9221899 into main Jan 7, 2025
25 checks passed
@jbelkins jbelkins deleted the jbe/protocol_test_manifest_refresh branch January 7, 2025 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants