chore: Add an integration test for SigV4A signing region #1852
Conversation
… SigV4A operation.
| key: SigningPropertyKeys.signingRegion | ||
| ) | ||
| XCTAssertNotNil(resolvedSigningRegion) | ||
| XCTAssertEqual(resolvedSigningRegion!, "*") // Assert that the resolved signing region is "*", as expected. |
There was a problem hiding this comment.
I think we either (or both) need to 1) re-write this test to use a real endpoint that resolves to 2 different regions and then make requests to both regions (as in the sev2 test code) 2) change this to a unit test since we don't actually need to make a real request to check if the resolvedSigningRegion is *
There was a problem hiding this comment.
- There's no real endpoint that resolves to 2 different regions atm. Every endpoint for every service that uses SigV4A uses
*forsigningRegionSetvalue, including SESv2 that caused the Sev2. - I think using integration test using the actual S3 operation flow is best for testing this, given doing so actually uses the typical auth flow for rules-based auth scheme resolution. Also, since it doesn't make actual network calls, there isn't a downside either for having the test.
There was a problem hiding this comment.
After discussion offline we concluded that maybe I could just use SESv2's multiregion (global) endpoint to test it in real-service scenario, but that was called off because all (all two of them) SESv2 API using global endpoints (sendEmail and sendBulkEmail) require involved email verification process that either requires manual verification via clicking a button in the actual email sent to the provided email address, or providing a key pair for a domain name.
There was a problem hiding this comment.
After offline discussion, having the test separated out like this vs. including it into S3 MRAP test is pending tie-breaker from Josh.
Issue #
2238
Description of changes
*(all SigV4A operations atm just have*for region field for SigV4A auth scheme property in the endpoint)New/existing dependencies impact assessment, if applicable
Conventional Commits
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.