address PR comments

awslabs · Dec 31, 2024 · 9c5123c · 9c5123c
1 parent d579676
commit 9c5123c
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 7 deletions.
diff --git a/...time/Sources/AWSClientRuntime/Middlewares/RpcV2CborValidateResponseHeaderMiddleware.swift b/...time/Sources/AWSClientRuntime/Middlewares/RpcV2CborValidateResponseHeaderMiddleware.swift
@@ -26,7 +26,9 @@ extension CborValidateResponseHeaderMiddleware: Interceptor {
     public typealias RequestType = HTTPRequest
     public typealias ResponseType = HTTPResponse
 
-    public func readBeforeDeserialization(context: some BeforeDeserialization<InputType, RequestType, ResponseType>) async throws {
+    public func readBeforeDeserialization(
+        context: some BeforeDeserialization<InputType, RequestType, ResponseType>
+    ) async throws {
         let response = context.getResponse()
         let smithyProtocolHeader = response.headers.value(for: "smithy-protocol")
 

diff --git a/...s/Core/AWSClientRuntime/Sources/AWSClientRuntime/Protocols/RpcV2Cbor/RpcV2CborError.swift b/...s/Core/AWSClientRuntime/Sources/AWSClientRuntime/Protocols/RpcV2Cbor/RpcV2CborError.swift
@@ -21,8 +21,6 @@ public struct RpcV2CborError: BaseError {
 
     @_spi(SmithyReadWrite)
     public init(httpResponse: HTTPResponse, responseReader: Reader, noErrorWrapping: Bool, code: String? = nil) throws {
-
-        // Improve this code
         switch responseReader.cborValue {
         case .map(let errorDetails):
             if case let .text(errorCode) = errorDetails["__type"] {

diff --git a/...oftware/amazon/smithy/aws/swift/codegen/protocols/rpcv2cbor/RpcV2CborProtocolGenerator.kt b/...oftware/amazon/smithy/aws/swift/codegen/protocols/rpcv2cbor/RpcV2CborProtocolGenerator.kt
@@ -29,22 +29,20 @@ class RpcV2CborProtocolGenerator : AWSHTTPBindingProtocolGenerator(RpcV2CborCust
     override fun addProtocolSpecificMiddleware(ctx: ProtocolGenerator.GenerationContext, operation: OperationShape) {
         super.addProtocolSpecificMiddleware(ctx, operation)
 
-        // Original instance of OperationInputBodyMiddleware checks if there is an HTTP Body, but for AWSJson protocols
-        // we always need to have an InputBodyMiddleware
         operationMiddleware.removeMiddleware(operation, "OperationInputBodyMiddleware")
         operationMiddleware.appendMiddleware(operation, OperationInputBodyMiddleware(ctx.model, ctx.symbolProvider, true))
 
         val hasEventStreamResponse = ctx.model.expectShape(operation.outputShape).hasTrait<StreamingTrait>()
         val hasEventStreamRequest = ctx.model.expectShape(operation.inputShape).hasTrait<StreamingTrait>()
 
-        // Determine the value of the Accept header
+        // Determine the value of the Accept header based on output shape
         val acceptHeaderValue = if (hasEventStreamResponse) {
             "application/vnd.amazon.eventstream"
         } else {
             "application/cbor"
         }
 
-        // Determine the value of the Content-Type header
+        // Determine the value of the Content-Type header based on input shape
         val contentTypeValue = if (hasEventStreamRequest) {
             "application/vnd.amazon.eventstream"
         } else {