Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

➕ add buffer as a dependency so assure support on newer builds of vite. #749

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jpengelbrecht
Copy link

Issue #, if available:
Buffer is no longer always added by default. so this module will fail on many of the new newer frameworks unless it is specically added as a polyfill.
Description of changes:
added npm module and imported it into file

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@jpengelbrecht jpengelbrecht requested a review from a team as a code owner August 17, 2023 09:06
@jpengelbrecht
Copy link
Author

jpengelbrecht commented Aug 17, 2023

an example of externalisation happening vitejs/vite#12975

@rob1121
Copy link

rob1121 commented Sep 8, 2023

Hi @jpengelbrecht is there a way to do this while waiting to merge your PR? like adding it to vite.config.js?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants