fix: check observer exists handleIncomingSubscriptionMessage #645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Bumping. What can I do here to help get it merged? |
|
Hello again. Can I do anything to assist this is being merged? |
|
It would be really really great if this could be merged 🙏 |
|
I opened a PR that fixes this following the existing code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No Issue, although similar in nature to #515 #544 #596 (and PRs #609, #595).
Check observer exists before calling its methods in AppSyncRealTimeSubscriptionHandshakeLink##_handleIncomingSubscriptionMessage
This observer is being defaulted to null here, so I assume checking that and ignoring the event after logging is fine since I would expect the method to bail there rather than initialize to an invalid value?
aws-mobile-appsync-sdk-js/packages/aws-appsync-subscription-link/src/realtime-subscription-handshake-link.ts
Line 641 in fc173bf
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
I Agree.