Disabling the validation tests due to the refactor in EC #167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pennyannn
force-pushed
the
yppe/fix-1720
branch
from
74cddc9
to
1d80662
Compare
pennyannn
force-pushed
the
yppe/fix-1720
branch
from
1d80662
to
932ed41
Compare
pennyannn
force-pushed
the
yppe/fix-1720
branch
from
0de432b
to
2f34d35
Compare
dkostic
approved these changes
Nov 20, 2024
|
this change should unblock: aws/aws-lc#2004. |
andrewhop
approved these changes
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AWS-LC is currently undergone disruptive changes in EC curves. We have disabled EC related proofs to allow the changes to be made as is stated in ticket P136759315. We found another validation test that needs to be disabled due to the EC changes in a recent PR, therefore disabling it to allow EC refactoring. We will reenable this validation test and EC proofs once the refactoring is done.
Ticket: P169003436
AWS-LC PR: aws/aws-lc#1720
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.