Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File backed hybrid heap implementation #101

Merged
merged 4 commits into from
Jan 2, 2021
Merged

File backed hybrid heap implementation #101

merged 4 commits into from
Jan 2, 2021

Conversation

MushMal
Copy link
Contributor

@MushMal MushMal commented Dec 23, 2020

Issue #23

Hybrid file backed heap implementation. Have not tested on Windows yet. Will stabilize with Travis run

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov-io
Copy link

codecov-io commented Dec 23, 2020

Codecov Report

Merging #101 (e7dd37c) into master (c020b49) will increase coverage by 0.40%.
The diff coverage is 84.94%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #101      +/-   ##
==========================================
+ Coverage   86.72%   87.12%   +0.40%     
==========================================
  Files          49       50       +1     
  Lines        8864     9109     +245     
==========================================
+ Hits         7687     7936     +249     
+ Misses       1177     1173       -4     
Impacted Files Coverage Δ
src/client/src/Client.c 91.73% <ø> (ø)
src/mkvgen/src/SpsParser.c 88.53% <ø> (ø)
src/utils/src/FileIo.c 87.00% <63.63%> (+31.11%) ⬆️
src/heap/src/HybridHeap.c 84.95% <75.00%> (-0.50%) ⬇️
src/heap/src/HybridFileHeap.c 88.11% <88.11%> (ø)
src/client/src/Stream.c 84.55% <100.00%> (ø)
src/client/src/StreamEvent.c 88.20% <100.00%> (ø)
src/heap/src/Common.c 99.11% <100.00%> (ø)
src/heap/src/Heap.c 100.00% <100.00%> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c020b49...e7dd37c. Read the comment docs.

…aught locally by the tools (odd)

Fixing Windows build issue with missing header
Fixing some warnings with unreferenced params that were only triggered by Windows VC compiler
Fixing some warnings with type cast loss of precision warnings triggered by Windows VC compiler
Copy link
Contributor

@hassanctech hassanctech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@MushMal MushMal merged commit 4df0449 into master Jan 2, 2021
@MushMal MushMal deleted the hybrid_file_heap branch January 2, 2021 05:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants