-
Notifications
You must be signed in to change notification settings - Fork 467
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MPHEE: first pass at adding logging for applications #962
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update this draft if you still would like this to be added
import software.amazon.kinesis.multilang.messages.ShardEndedMessage; | ||
import software.amazon.kinesis.multilang.messages.ShutdownRequestedMessage; | ||
import software.amazon.kinesis.multilang.messages.StatusMessage; | ||
import software.amazon.kinesis.multilang.messages.*; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should not be adding wildcards for imports. This should explictly state all the things we need to import
log.info("Client logging: " + this.message); | ||
} | ||
|
||
public Function<String, Boolean> getLogger() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks to be returning only a boolean, not a Function<String, Boolean>. Also everything returns true. What is the benefit of returning a value
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's returning a function
return (m) -> {
log.debug(m);
return true;
};
Not sure a better return type since Function
requires one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't looked at this for a couple years now. If you find it useful I can fix things up but I'm not using kinesis anymore.
log.info("Client logging: " + this.message); | ||
} | ||
|
||
public Function<String, Boolean> getLogger() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's returning a function
return (m) -> {
log.debug(m);
return true;
};
Not sure a better return type since Function
requires one.
MultiLang Daemon StdLogger call
Adding the ability for the clients to send logging messages through the normal stdout by having the KCL process new LogMessages
WIP right now
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Python side maybe?