Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix awslogs test target and add more test scenarios #77

Merged
merged 1 commit into from
Sep 28, 2023

Conversation

ningziwen
Copy link
Member

@ningziwen ningziwen commented Sep 25, 2023

Description of changes:

  • Fixed the existing awslogs ci
  • Added more test scenarios
  • Added doc for special failure scenario

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@ningziwen ningziwen force-pushed the aws-more branch 27 times, most recently from 0682746 to 6aac1ca Compare September 26, 2023 05:27
@ningziwen ningziwen changed the title test: add more test scenarios for awslogs shim logger ci: fix awslogs test target and add more test scenarios Sep 26, 2023
@ningziwen ningziwen marked this pull request as ready for review September 26, 2023 05:30
@ningziwen ningziwen force-pushed the aws-more branch 2 times, most recently from d4cb2cb to 0afd927 Compare September 26, 2023 20:56
sam-berning
sam-berning previously approved these changes Sep 26, 2023
e2e/awslogs_test.go Outdated Show resolved Hide resolved
ginglis13
ginglis13 previously approved these changes Sep 26, 2023
e2e/awslogs_test.go Show resolved Hide resolved
@ningziwen ningziwen dismissed stale reviews from ginglis13 and sam-berning via f598367 September 26, 2023 21:58
@ningziwen ningziwen force-pushed the aws-more branch 15 times, most recently from 28294f5 to 0469952 Compare September 28, 2023 05:08
@ningziwen ningziwen merged commit 12b948e into aws:main Sep 28, 2023
13 checks passed
@ningziwen ningziwen deleted the aws-more branch September 28, 2023 17:43
ningziwen added a commit to ningziwen/shim-loggers-for-containerd that referenced this pull request Sep 28, 2023
*Description of changes:*

* Fixed the existing awslogs ci
* Added more test scenarios
* Added doc for special failure scenario


By submitting this pull request, I confirm that you can use, modify,
copy, and redistribute this contribution, under the terms of your
choice.

Signed-off-by: Ziwen Ning <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants