ci: add Splunk basic e2e tests #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ningziwen
force-pushed
the
splunk
branch
19 times, most recently
from
a10cb0c to
c95278c
Compare
weikequ
reviewed
Sep 21, 2023
Signed-off-by: Ziwen Ning <[email protected]>
weikequ
approved these changes
Sep 21, 2023
sam-berning
approved these changes
Sep 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
The test is not perfect but can be used for basic validation because the containerd task is ran successfully with the Splunk shim logger. It is nice to validate the logs in Splunk after it. It is not straightforward to do that so opened issue to track it. #74
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.