Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Docker dependency to v20.10.25 #49

Closed

Conversation

austinvazquez
Copy link
Member

@austinvazquez austinvazquez commented May 24, 2023

Issue #, if available:
#48

Description of changes:
This change updates the docker/docker dependency to v20.10.25.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@austinvazquez
Copy link
Member Author

CI failures don't make sense based on the updates here. Going to attempt to resolve those first starting with #41

@austinvazquez austinvazquez force-pushed the update-docker-dependency branch from da74dbd to 3a9428c Compare May 24, 2023 20:28
BinSquare
BinSquare previously approved these changes Jul 12, 2023
@ningziwen
Copy link
Member

@austinvazquez LGTM. Could you resolve the conflict? Do you know why dependabot can't address this update?

@austinvazquez austinvazquez force-pushed the update-docker-dependency branch from 3a9428c to 2340bd4 Compare July 18, 2023 13:28
@austinvazquez
Copy link
Member Author

@austinvazquez LGTM. Could you resolve the conflict? Do you know why dependabot can't address this update?

Updated. Not certain the issue with dependabot. Possibly related to the replace. Although I see, which refer to a moby patch. I am uncertain if this is upstream and will need to investigate more.

  1. a16272f
  2. Upgrade consumed moby to latest release v20.10.13 #21

@BinSquare
Copy link
Contributor

Let's hold-off on this, the patch is from dharma github.com/dharmadheeraj/moby v20.10.14-0.20220615184823-6b50baca60ea+incompatible to prevent a double calling of createLogStreams for Fargate tasks.

@BinSquare BinSquare dismissed their stale review July 18, 2023 17:57

This change will cause a regression

@ningziwen
Copy link
Member

@BinSquare Could you point me the required change in patch? Is there an existing PR to merge it to moby? If not, I'd like to take a look to see if it is possible to merge it.

@austinvazquez
Copy link
Member Author

Superseded by #107

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants