Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to go 1.16 and add darwin-arm64 support. #42

Open
wants to merge 7 commits into
base: mainline
Choose a base branch
from

Conversation

DennoVonDiesel
Copy link

go 1.16 is required for darwin-arm64 support. I've added this to the build process.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@williantenfen
Copy link

nice

@yuting-fan

@williantenfen
Copy link

@DennoVonDiesel when I try to use the install file as: install -i /usr/local/sessionmanagerplugin -b /usr/local/bin/session-manager-plugin from path session-manager-plugin/Tools/src/darwin it displays:

install: illegal option -- i
usage: install [-bCcpSsv] [-B suffix] [-f flags] [-g group] [-m mode]
               [-o owner] file1 file2
       install [-bCcpSsv] [-B suffix] [-f flags] [-g group] [-m mode]
               [-o owner] file1 ... fileN directory
       install -d [-v] [-g group] [-m mode] [-o owner] directory ...

I'm missing some steps?

@DennoVonDiesel
Copy link
Author

@williantenfen I don't see that the system command install has a -i option on either darwin or linux. I think the correct way is to unzip the bundle file that gets created after building the package and run that installer.

@williantenfen
Copy link

thanks! got it. working fine!

@andymac4182
Copy link

This is great hopefully @Yangtao-Hua or @yuting-fan can look at merging soon.

@kylebebak
Copy link

@Yangtao-Hua @yuting-fan

It would be really nice to get session-manager-plugin working for M1 machines without having to use a fork of this library!

@Yangtao-Hua
Copy link
Contributor

Thank you for the changes, we noticed it is highly required feature, it is in our plan.

@andymac4182
Copy link

Do you have an ETA @Yangtao-Hua ?

@andymac4182 andymac4182 mentioned this pull request Aug 29, 2022
@andymac4182
Copy link

@Yangtao-Hua This is flagged as a highly required feature but no movement in over 3 months.

Should any community work towards this repository move away from AWS and be managed by the community due to the lack of engagement?

@@ -11,6 +11,7 @@
// either express or implied. See the License for the specific language governing
// permissions and limitations under the License.

//go:build darwin || freebsd || linux || netbsd || openbsd

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think go:build isn't added until 1.17.

Any reason not to upgrade to latest go version (which also removes the +build lines)?

@nitikaaws
Copy link
Contributor

We are actively working to add darwin-arm64 support and this change is currently under review. Will keep this thread updated on the release as we make progress.

@andymac4182
Copy link

Any update @nitikaaws ?

@mbaranovski
Copy link

Nice definition of "actively" @nitikaaws
Seriously guys... what's taking so long, this is absurd.

cc. @yuting-fan @Yangtao-Hua @YujiaozhAws

@nitikaaws
Copy link
Contributor

Apologies for the delay in releasing the support for darwin-arm64! Our team is looking into this and will provide an update when we are closer to the release.

@andymac4182
Copy link

@nitikaaws Any chance of a community release? You said you were reviewing this change in November.

@nitikagoyal87
Copy link

Session Manager Plugin support for darwin-arm64 has been released with version 1.2.463.0. This pull request has been incorporated in 60f4fa7 commit. Thanks for your patience and support, please let us know your feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants