Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reverting numpy 1.21.2 to 1.19.2, updating boto3 to 1.24.17, fixing docker build and adding regression #127

Merged
merged 1 commit into from
Jul 15, 2022
Merged

Reverting numpy 1.21.2 to 1.19.2, updating boto3 to 1.24.17, fixing docker build and adding regression #127

merged 1 commit into from
Jul 15, 2022

Conversation

NikhilRaverkar
Copy link
Contributor

@NikhilRaverkar NikhilRaverkar commented Jul 14, 2022 •
edited
Loading

Issue #, if available:

  • fixing Update of numpy to version 1.21.0 causing conflict with pyarrow version #106
  • Adding regression to catch the re occurrence of this issue.
  • Updating boto3 to 1.24.17 (to make it similar as 1.0 version)
  • Build failures during build
    Description of changes:
  • Numpy 1.2.x broke the integration with Pyarrow 1.0. Rolling back numpy version to 1.19.2
  • Added Regression test
  • Updated Docker build file to resolve build failures
    By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@NikhilRaverkar NikhilRaverkar force-pushed the issue_106_0_23_1 branch 2 times, most recently from f776c46 to 88e125a Compare July 14, 2022 23:09
@NikhilRaverkar NikhilRaverkar changed the title fixing issue# 106 Reverting numpy 1.21.2 to 1.19.2 and adding regression Jul 14, 2022
@NikhilRaverkar NikhilRaverkar marked this pull request as ready for review July 15, 2022 14:55
@NikhilRaverkar NikhilRaverkar requested a review from mabunday July 15, 2022 14:55
@NikhilRaverkar NikhilRaverkar changed the title Reverting numpy 1.21.2 to 1.19.2 and adding regression Reverting numpy 1.21.2 to 1.19.2, updating boto3 to 1.24.17 and adding regression Jul 15, 2022
@NikhilRaverkar NikhilRaverkar changed the title Reverting numpy 1.21.2 to 1.19.2, updating boto3 to 1.24.17 and adding regression Reverting numpy 1.21.2 to 1.19.2, updating boto3 to 1.24.17, fixed docker build and adding regression Jul 15, 2022
@NikhilRaverkar NikhilRaverkar changed the title Reverting numpy 1.21.2 to 1.19.2, updating boto3 to 1.24.17, fixed docker build and adding regression Reverting numpy 1.21.2 to 1.19.2, updating boto3 to 1.24.17, fixing docker build and adding regression Jul 15, 2022
@mabunday
Copy link
Contributor

Thanks for the quick turnaround on these changes!

@NikhilRaverkar NikhilRaverkar merged commit d8760d8 into 0.23-1 Jul 15, 2022
@mabunday mabunday deleted the issue_106_0_23_1 branch August 4, 2022 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mabunday mabunday mabunday approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NikhilRaverkar @mabunday