Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

if al2023, then install nftables #1515

Merged
merged 1 commit into from
Aug 26, 2024
Merged

Conversation

zachdorame
Copy link
Contributor

Issue #, if available: N/A

Description of changes:

For supporting the nftables-based backend beta feature in EKS 1.31 for kube-proxy, we'll need to install ntables into the al2023 image used to build kube-proxy.
This PR is a very tiny change to allow the nftables binary to be installed

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@eks-distro-bot
Copy link
Collaborator

Hi @zachdorame. Thanks for your PR.

I'm waiting for a aws member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@github-actions github-actions bot added the minimal-image Changes related to the minimal-images or tooling label Aug 23, 2024
@jaydeokar
Copy link

jaydeokar commented Aug 23, 2024

@jaxesn @markapruett
Would like to know your thoughts on this change. This is in for a beta feature that is going in v1.31.0.

https://kubernetes.io/blog/2024/08/13/kubernetes-v1-31-release/#nftables-backend-for-kube-proxy
https://github.com/kubernetes/enhancements/blob/master/keps/sig-network/3866-nftables-proxy/README.md
The requirement is that nftable version be greater than v1.0.1 which is only possible with AL2023 right now

Do you prefer having a new dockerfile or reusing this one as the change is minimal

@jaydeokar
Copy link

/ok-to-test

@eks-distro-bot
Copy link
Collaborator

@jaydeokar: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/ok-to-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jaxesn
Copy link
Member

jaxesn commented Aug 23, 2024

I think this makes sense. Just wanted to confirm tho, the 1.31 kube-proxy image will be based off the al23 base? What is the current kube-proxy image based off?

@zachdorame
Copy link
Contributor Author

The current kube-proxy is based off the al2 base. However, we have evidence that there's no regressions in switching to al23 base as the al23 base kube-proxy passes our end-to-end tests.

@jaxesn
Copy link
Member

jaxesn commented Aug 23, 2024

Makes sense to me! 🚢

@jaydeokar
Copy link

/approve

1 similar comment
@markapruett
Copy link
Member

/approve

@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jaydeokar, markapruett

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@vineeth-bandi vineeth-bandi merged commit 48563c9 into aws:main Aug 26, 2024
37 of 38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm minimal-image Changes related to the minimal-images or tooling needs-ok-to-test size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants