-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
if al2023, then install nftables #1515
Conversation
Hi @zachdorame. Thanks for your PR. I'm waiting for a aws member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@jaxesn @markapruett https://kubernetes.io/blog/2024/08/13/kubernetes-v1-31-release/#nftables-backend-for-kube-proxy Do you prefer having a new dockerfile or reusing this one as the change is minimal |
/ok-to-test |
@jaydeokar: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
I think this makes sense. Just wanted to confirm tho, the 1.31 kube-proxy image will be based off the al23 base? What is the current kube-proxy image based off? |
The current kube-proxy is based off the al2 base. However, we have evidence that there's no regressions in switching to al23 base as the al23 base kube-proxy passes our end-to-end tests. |
Makes sense to me! 🚢 |
/approve |
1 similar comment
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jaydeokar, markapruett The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Issue #, if available: N/A
Description of changes:
For supporting the nftables-based backend beta feature in EKS 1.31 for kube-proxy, we'll need to install ntables into the al2023 image used to build kube-proxy.
This PR is a very tiny change to allow the nftables binary to be installed
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.