Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Markdown in eks-distro-base/README.md #1513

Merged
merged 1 commit into from
Aug 26, 2024
Merged

Fixed Markdown in eks-distro-base/README.md #1513

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions eks-distro-base/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ contain and are intended to only run a static golang binary. These containers c
for [kindnetd](https://github.com/aws/eks-anywhere-build-tooling/blob/main/projects/kubernetes-sigs/kind/images/kindnetd/Dockerfile) in the EKS-A kind node-image. The list of packages
is tracked in [iptables](../eks-distro-minimal-packages/linux_amd64/iptables).

[minimal-base-glibc] is used as the base image for any image which contains golang binaries which are compiled with `CGO_ENABLED=1` or for containers which require other
[minimal-base-glibc](./Dockerfile.minimal-base-glibc) is used as the base image for any image which contains golang binaries which are compiled with `CGO_ENABLED=1` or for containers which require other
standard linux dependencies, such as the iptables variant. The list of packages
is tracked in [glibc](../eks-distro-minimal-packages/linux_amd64/glibc).

Expand All @@ -50,7 +50,7 @@ to date via periodic prow jobs. These files can found at [eks-distro-minimal-pa

There are multiple approaches taken to getting the final list of RPMs that should be installed and how they are installed depending on the specific use case.

##**Recommended**
## **Recommended**

When the desired executables are known, using the [install_binary](./scripts/install_binary) script is the easiest and best approach. This approach uses `yum provides` to determine
the RPM which includes the desired executable, downloads and extracts the RPM and finally manually copies the specific executable (along with text files in `/etc` and `/usr/share` like licenses).
Expand Down Expand Up @@ -87,7 +87,7 @@ common failures here, but not all so pay close attention to the output when addi

### Creating new images

Creating new images based off minimal variants where new packages are necessary will require a multi-stage build using the builder images which are also pushed to [ECR](https://gallery.ecr.aws/eks-distro-build-tooling].
Creating new images based off minimal variants where new packages are necessary will require a multi-stage build using the builder images which are also pushed to [ECR](https://gallery.ecr.aws/eks-distro-build-tooling).
To ensure consistency and proper cleanup during install and removal of packages, the [scripts](./scripts) are added to `/usr/bin` and are used extensively throughout the variant Dockerfiles.

#### Examples
Expand Down
Loading