Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update golang in builder-base and eks-distro-base #1503

Closed

Conversation

eks-distro-pr-bot
Copy link
Contributor

This PR updates the base image tag in builder-base and eks-distro-base with the tag of the newly-built EKS Distro base image.

Note

Merging this PR may trigger SNS messages, tickets being cut and PRs being opened by the bot across various repos.

Do not merge without:

  • carefully reviewing the package and file changes in the files under eks-distro-base-minimal-packages
  • checking out the PR locally and running make test-all-minimal-images to ensure newly built images pass smoke tests

/hold

Click here to view job logs.

By submitting this pull request,I confirm that you can use, modify, copy,and redistribute this contribution,under the terms of your choice.

@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign varma-maryala for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@github-actions github-actions bot added the minimal-image Changes related to the minimal-images or tooling label Aug 16, 2024
@eks-distro-bot
Copy link
Collaborator

Hi @eks-distro-pr-bot. Thanks for your PR.

I'm waiting for a aws member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@vineeth-bandi
Copy link
Member

/ok-to-test

@eks-distro-bot
Copy link
Collaborator

@eks-distro-pr-bot: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
eks-distro-base-test-presubmit 6388454 link true /test eks-distro-base-test-presubmit

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants