Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix new golang minor version release automation path #1500

Merged

Conversation

rcrozean
Copy link
Member

@rcrozean rcrozean commented Aug 14, 2024

Issue #, if available:

Description of changes:
use minorversion instead of MINORVERSION in sed command. MINORVERSION is used in yq and not being persisted as expected. minorversion should accomplish same thing and shows as set correctly in logs.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@github-actions github-actions bot added the minimal-image Changes related to the minimal-images or tooling label Aug 14, 2024
@vineeth-bandi
Copy link
Member

/lgtm

@vineeth-bandi
Copy link
Member

/approve

@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vineeth-bandi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@vineeth-bandi vineeth-bandi merged commit 6138340 into aws:main Aug 14, 2024
36 of 37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm minimal-image Changes related to the minimal-images or tooling size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants