Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trigger builder-base update for go 1.21.11, 1.22.4 #1433

Merged
merged 1 commit into from
Jun 11, 2024

Conversation

sp1999
Copy link
Member

@sp1999 sp1999 commented Jun 5, 2024

Issue #, if available:

Description of changes:
#1432 and #1435

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign markapruett for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@github-actions github-actions bot added minimal-image Changes related to the minimal-images or tooling builder-base labels Jun 5, 2024
@sp1999 sp1999 force-pushed the build-base branch 2 times, most recently from e5a127b to 72ec1a5 Compare June 6, 2024 01:59
@sp1999 sp1999 changed the title Trigger builder-base update for go 1.22.4 Trigger builder-base update for go 1.21.11, 1.22.4 Jun 6, 2024
@sp1999
Copy link
Member Author

sp1999 commented Jun 6, 2024

/retest

5 similar comments
@sp1999
Copy link
Member Author

sp1999 commented Jun 6, 2024

/retest

@sp1999
Copy link
Member Author

sp1999 commented Jun 6, 2024

/retest

@bhavi-koduru
Copy link
Member

/retest

@sp1999
Copy link
Member Author

sp1999 commented Jun 10, 2024

/retest

@rcrozean
Copy link
Member

/retest

@eks-distro-bot
Copy link
Collaborator

@sp1999: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
eks-distro-base-tooling-presubmits-windows 6f14f1f link true /test eks-distro-base-tooling-presubmits-windows

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rcrozean rcrozean merged commit 75650be into aws:main Jun 11, 2024
38 of 40 checks passed
@sp1999 sp1999 deleted the build-base branch June 11, 2024 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
builder-base minimal-image Changes related to the minimal-images or tooling size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants