Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trigger builder-base update for go 1.21.10, 1.22.3 #1422

Merged
merged 1 commit into from
May 16, 2024
Merged

Conversation

xdu31
Copy link
Member

@xdu31 xdu31 commented May 16, 2024

Issue #, if available:

Description of changes:
#1421 and #1420

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@github-actions github-actions bot added minimal-image Changes related to the minimal-images or tooling builder-base labels May 16, 2024
@xdu31
Copy link
Member Author

xdu31 commented May 16, 2024

/retest

@eks-distro-bot
Copy link
Collaborator

@xdu31: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
eks-distro-base-tooling-presubmits-windows 7c5f963 link true /test eks-distro-base-tooling-presubmits-windows

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@zafs23
Copy link
Contributor

zafs23 commented May 16, 2024

/lgtm

@xdu31
Copy link
Member Author

xdu31 commented May 16, 2024

/approve

@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xdu31

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@xdu31 xdu31 merged commit 56405e8 into aws:main May 16, 2024
38 of 40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved builder-base lgtm minimal-image Changes related to the minimal-images or tooling size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants