Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle creation of RELEASE file in new Go version Release #1342

Merged
merged 2 commits into from
Feb 14, 2024

Conversation

xdu31
Copy link
Member

@xdu31 xdu31 commented Feb 13, 2024

Issue #, if available:

Description of changes:

Handle creation of RELEASE file in new Go version Release

When we run

./eksGoRelease release --eksGoReleases=1.22.0 -e [email protected] -u xdu31

It errors out with the follow error:

finding filename	{"filename": "projects/golang/go/1.22/RELEASE", "error": "file not found"}
Reading file	{"file": "projects/golang/go/1.22/RELEASE", "error": "file not found"}
increment release	{"error": "file not found"}
Error: you have failed this automation: file not found

This happens when it is a new Go version release

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@rcrozean
Copy link
Member

/lgtm

@rcrozean
Copy link
Member

/lgtm

@xdu31
Copy link
Member Author

xdu31 commented Feb 14, 2024

/approve

@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xdu31

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@eks-distro-bot eks-distro-bot merged commit 68e1ffc into aws:main Feb 14, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants