Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds upx compression to our biggest bins in builder-base #1228

Merged
merged 1 commit into from
Nov 11, 2023

Conversation

jaxesn
Copy link
Member

@jaxesn jaxesn commented Oct 31, 2023

Issue #, if available:

Description of changes:

@abhay-krishna suggested we see what happens if we use upx to compress some of our larger bins, esp the golang statically compiled ones. I gave it a shot and actually it does add pretty decent savings in terms of space, esp on the decompressed final image, it ends up going from ~3.8GB to ~2.4GB. Some of this is from the python and golang cleanup i am also doing here, but a good chunk is the upx compression. The download size savings is probably 300-400MB, just per the ECR ui in my dev account.

I have tested this by building all of the eks-a stack. I feel pretty good that that compressed binaries do not cause any issues...

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@eks-distro-bot
Copy link
Collaborator

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@jaxesn jaxesn marked this pull request as ready for review November 1, 2023 13:24
@jaxesn jaxesn force-pushed the jgw/upx-stuff branch 2 times, most recently from 145c1e0 to bb290ce Compare November 1, 2023 17:18
@rcrozean
Copy link
Member

/lgtm

@jaxesn
Copy link
Member Author

jaxesn commented Nov 10, 2023

/approve

@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jaxesn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@abhay-krishna
Copy link
Member

/lgtm

@eks-distro-bot eks-distro-bot merged commit 06bdab1 into aws:main Nov 11, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants