adds upx compression to our biggest bins in builder-base #1228
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
@abhay-krishna suggested we see what happens if we use upx to compress some of our larger bins, esp the golang statically compiled ones. I gave it a shot and actually it does add pretty decent savings in terms of space, esp on the decompressed final image, it ends up going from ~3.8GB to ~2.4GB. Some of this is from the python and golang cleanup i am also doing here, but a good chunk is the upx compression. The download size savings is probably 300-400MB, just per the ECR ui in my dev account.
I have tested this by building all of the eks-a stack. I feel pretty good that that compressed binaries do not cause any issues...
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.