Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes ansible perms for imagebuilder user #1226

Merged
merged 1 commit into from
Oct 31, 2023

Conversation

jaxesn
Copy link
Member

@jaxesn jaxesn commented Oct 31, 2023

Issue #, if available:

Description of changes:

In eks-a we use the imagebuilder user instead of root. This consistently trips us up due to file perms. This fixes the perms and adds a simple validation to make sure the image builder user can run the tools installed with ansible.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@jaxesn jaxesn force-pushed the jgw/fix-ansible-perm branch from c4ab267 to 76f7586 Compare October 31, 2023 16:14
Copy link
Member

@abhay-krishna abhay-krishna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhay-krishna

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@eks-distro-bot eks-distro-bot merged commit d0884d2 into aws:main Oct 31, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants