installs python 3.9 from minimal base image into builder base #1210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaxesn
commented
Oct 13, 2023
builder-base/Dockerfile
Outdated
| unlink /ansible/usr/bin/python && \ | ||
| rm -rf /var/lib/ | ||
|
|
||
| FROM ${BUILDER_IMAGE} as ansible-al23 |
There was a problem hiding this comment.
for the al23 base image continue doing what we were since that version includes python 3.9
jaxesn
commented
Oct 13, 2023
| endef | ||
|
|
||
| define NEWLINE | ||
|
|
||
|
|
||
| endef | ||
|
|
||
| REALPATH=TZ=utc $(shell if [ "$$(uname -s)" = "Darwin" ] && command -v grealpath &> /dev/null; then echo grealpath; else echo realpath; fi) |
jaxesn
force-pushed
the
jgw/builder-base-3.9
branch
3 times, most recently
from
12713c1 to
d4b7972
Compare
|
/hold |
jaxesn
force-pushed
the
jgw/builder-base-3.9
branch
from
d4b7972 to
1b10f86
Compare
|
/unhold |
markapruett
approved these changes
Oct 16, 2023
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jaxesn The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
For the later versions of ansible, which is only used by our image-builder builds, we need a python 3.9 version. AL2 does not ship a 3.9 version by default. When we originally built the emissary image, which also needed 3.9, we built a al2 based minimal python image building python from source.
This PR copies python 3.9 from the minimal image into the builder base instead of using 3.8 from yum. This shouldnt affect any of the builds since we are pretty sure the only build relying on python3 is the image-builder builds.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.