Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update golang spec to include go env #1171

Merged
merged 1 commit into from
Sep 20, 2023

Conversation

danbudris
Copy link
Member

@danbudris danbudris commented Sep 20, 2023

Issue #, if available:

Description of changes:
update Go 1.21 spec to include the go.env in the go root during the build. Thx @jaxesn

https://src.fedoraproject.org/rpms/golang/c/e1a400ab5f64e0883f3516f49f8d7e25dcdd9449?branch=rawhide

We are not also taking the "0001-Modify-go.env" patch as the change already exits in this utility patch.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@github-actions github-actions bot added golang go Pull requests that update Go code go1.21 projects Updates or changes to the projects being built labels Sep 20, 2023
@danbudris
Copy link
Member Author

/approve

@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danbudris

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@eks-distro-bot eks-distro-bot merged commit d37df4e into main Sep 20, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved go Pull requests that update Go code go1.21 golang lgtm projects Updates or changes to the projects being built size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants