-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Copy over CAPT APIs to local package #9114
Conversation
238821c
to
36de4b8
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9114 +/- ##
==========================================
- Coverage 72.41% 72.35% -0.07%
==========================================
Files 578 585 +7
Lines 45589 45683 +94
==========================================
+ Hits 33015 33055 +40
- Misses 10838 10890 +52
- Partials 1736 1738 +2 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Rahul Ganesh <[email protected]>
36de4b8
to
5a072cf
Compare
Signed-off-by: Rahul Ganesh <[email protected]>
@rahulbabu95: you cannot LGTM your own PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rahulbabu95 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Issue #, if available:
Description of changes:
#9094 added bootOptions to ControlPlane and worker template. We parse this template to corresponding upstream objects. Since in the current version of upstream projects that EKS-A consumes, these fields aren't supported those values are ignored during the parsing. Ideally we want EKS-A to consume the latest CAPT version. But upgrading the CAPT CRDs via the go.mod causes dependency issues with regard to controller-runtime. CAPT and Tink repos both have newer versions than EKSA. The upstream controller runtime version is at
v0.19.3
and eks-anywhere is currently atv0.16.5
and the version difference is too great to be overcome. This is a short term fix. Long term EKSA needs to update to the latest controller-runtime or each of the CAPT and Tink repos needs to figure a way to have the CRD go definitions not import controller runtime and be their own Go modules.Testing (if applicable):
Built a local binary and tested with bundles override to see the
bootOptions
field was populated in the TinkerbellMachineTempalte.Documentation added/planned (if applicable):
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.