Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy over CAPT APIs to local package #9114

Merged
merged 2 commits into from
Dec 27, 2024

Conversation

rahulbabu95
Copy link
Member

@rahulbabu95 rahulbabu95 commented Dec 26, 2024

Issue #, if available:

Description of changes:
#9094 added bootOptions to ControlPlane and worker template. We parse this template to corresponding upstream objects. Since in the current version of upstream projects that EKS-A consumes, these fields aren't supported those values are ignored during the parsing. Ideally we want EKS-A to consume the latest CAPT version. But upgrading the CAPT CRDs via the go.mod causes dependency issues with regard to controller-runtime. CAPT and Tink repos both have newer versions than EKSA. The upstream controller runtime version is at v0.19.3 and eks-anywhere is currently at v0.16.5 and the version difference is too great to be overcome. This is a short term fix. Long term EKSA needs to update to the latest controller-runtime or each of the CAPT and Tink repos needs to figure a way to have the CRD go definitions not import controller runtime and be their own Go modules.

Testing (if applicable):
Built a local binary and tested with bundles override to see the bootOptions field was populated in the TinkerbellMachineTempalte.

Documentation added/planned (if applicable):

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@eks-distro-bot eks-distro-bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Dec 26, 2024
@rahulbabu95 rahulbabu95 force-pushed the l3/copy-capt-apis branch 2 times, most recently from 238821c to 36de4b8 Compare December 27, 2024 18:21
Copy link

codecov bot commented Dec 27, 2024

Codecov Report

Attention: Patch coverage is 42.55319% with 54 lines in your changes missing coverage. Please review.

Project coverage is 72.35%. Comparing base (2d73db2) to head (cb6586c).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
.../capt/v1beta1/tinkerbellmachinetemplate_webhook.go 0.00% 24 Missing ⚠️
...nkerbell/capt/v1beta1/tinkerbellcluster_webhook.go 0.00% 20 Missing ⚠️
...nkerbell/capt/v1beta1/tinkerbellmachine_webhook.go 71.42% 8 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9114      +/-   ##
==========================================
- Coverage   72.41%   72.35%   -0.07%     
==========================================
  Files         578      585       +7     
  Lines       45589    45683      +94     
==========================================
+ Hits        33015    33055      +40     
- Misses      10838    10890      +52     
- Partials     1736     1738       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Rahul Ganesh <[email protected]>
@eks-distro-bot
Copy link
Collaborator

@rahulbabu95: you cannot LGTM your own PR.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rahulbabu95
Copy link
Member Author

/approve

@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rahulbabu95

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rahulbabu95 rahulbabu95 merged commit 0bf9d3c into aws:main Dec 27, 2024
13 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants