Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tinkerbell airgapped e2e tests #7117

Merged
merged 1 commit into from
Dec 1, 2023

Conversation

panktishah26
Copy link
Member

@panktishah26 panktishah26 commented Dec 1, 2023

Description of changes:

TestTinkerbellAirgappedKubernetes128BottleRocketRegistryMirror
TestTinkerbellAirgappedKubernetes128BottlerocketProxyConfigFlow
TestTinkerbellAirgappedKubernetes128UbuntuProxyConfigFlow

Above e2e tests always used to download 1.24 kube version image and/or used to fail with below error,

❌ Validation failed {"validation": "tinkerbell Provider setup is valid", "error": "missing kube version from OSImageURL: url=http://10.80.18.122:8080/bottlerocket.img.gz, version=1.28", "remediation": ""}

This PR fixes this issue.

Testing (if applicable):

Documentation added/planned (if applicable):

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@eks-distro-bot eks-distro-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Dec 1, 2023
Copy link

codecov bot commented Dec 1, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a1dbf9c) 71.56% compared to head (bde5991) 71.56%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7117   +/-   ##
=======================================
  Coverage   71.56%   71.56%           
=======================================
  Files         545      545           
  Lines       42323    42323           
=======================================
  Hits        30288    30288           
  Misses      10343    10343           
  Partials     1692     1692           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@d8660091
Copy link
Member

d8660091 commented Dec 1, 2023

/lgtm

@panktishah26
Copy link
Member Author

/cherry-pick release0.18

@eks-distro-pr-bot
Copy link
Contributor

@panktishah26: once the present PR merges, I will cherry-pick it on top of release0.18 in a new PR and assign it to you.

In response to this:

/cherry-pick release0.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@eks-distro-bot eks-distro-bot merged commit a3def9f into aws:main Dec 1, 2023
11 of 12 checks passed
@eks-distro-pr-bot
Copy link
Contributor

@panktishah26: cannot checkout release0.18: error checking out release0.18: exit status 1. output: error: pathspec 'release0.18' did not match any file(s) known to git

In response to this:

/cherry-pick release0.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@panktishah26
Copy link
Member Author

/cherry-pick release-0.18

@eks-distro-pr-bot
Copy link
Contributor

@panktishah26: new pull request created: #7119

In response to this:

/cherry-pick release-0.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants