-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix tinkerbell airgapped e2e tests #7117
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7117 +/- ##
=======================================
Coverage 71.56% 71.56%
=======================================
Files 545 545
Lines 42323 42323
=======================================
Hits 30288 30288
Misses 10343 10343
Partials 1692 1692 ☔ View full report in Codecov by Sentry. |
/lgtm |
/cherry-pick release0.18 |
@panktishah26: once the present PR merges, I will cherry-pick it on top of release0.18 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@panktishah26: cannot checkout In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cherry-pick release-0.18 |
@panktishah26: new pull request created: #7119 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Description of changes:
TestTinkerbellAirgappedKubernetes128BottleRocketRegistryMirror
TestTinkerbellAirgappedKubernetes128BottlerocketProxyConfigFlow
TestTinkerbellAirgappedKubernetes128UbuntuProxyConfigFlow
Above e2e tests always used to download 1.24 kube version image and/or used to fail with below error,
❌ Validation failed {"validation": "tinkerbell Provider setup is valid", "error": "missing kube version from OSImageURL: url=http://10.80.18.122:8080/bottlerocket.img.gz, version=1.28", "remediation": ""}
This PR fixes this issue.
Testing (if applicable):
Documentation added/planned (if applicable):
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.