Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: docs to show apple and arm support #7067

Merged
merged 5 commits into from
Dec 10, 2023

Conversation

RazaGR
Copy link
Contributor

@RazaGR RazaGR commented Nov 21, 2023

This fix the docs to show that eks now supports apple and arm processor.

related issue #182

@eks-distro-bot
Copy link
Collaborator

Hi @RazaGR. Thanks for your PR.

I'm waiting for a aws member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@eks-distro-bot eks-distro-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 21, 2023
Copy link
Member

@chrisnegus chrisnegus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of punctuation suggestions.

docs/content/en/docs/getting-started/docker/_index.md Outdated Show resolved Hide resolved
docs/content/en/docs/getting-started/install/_index.md Outdated Show resolved Hide resolved
Copy link
Contributor

@chrisdoherty4 chrisdoherty4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates. Some minor modifications.

RazaGR and others added 2 commits November 27, 2023 18:25
Copy link

codecov bot commented Nov 30, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2d2346e) 71.35% compared to head (e5523cd) 71.56%.
Report is 25 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7067      +/-   ##
==========================================
+ Coverage   71.35%   71.56%   +0.20%     
==========================================
  Files         544      545       +1     
  Lines       41966    42318     +352     
==========================================
+ Hits        29943    30283     +340     
+ Misses      10345    10343       -2     
- Partials     1678     1692      +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chrisnegus
Copy link
Member

/cherry-pick release-0.18

@eks-distro-pr-bot
Copy link
Contributor

@chrisnegus: once the present PR merges, I will cherry-pick it on top of release-0.18 in a new PR and assign it to you.

In response to this:

/cherry-pick release-0.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@eks-distro-bot eks-distro-bot merged commit c4d01fe into aws:main Dec 10, 2023
9 checks passed
@eks-distro-pr-bot
Copy link
Contributor

@chrisnegus: new pull request created: #7153

In response to this:

/cherry-pick release-0.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/docs Documentation documentation lgtm ok-to-test size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants