-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: docs to show apple and arm support #7067
fix: docs to show apple and arm support #7067
Conversation
Hi @RazaGR. Thanks for your PR. I'm waiting for a aws member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of punctuation suggestions.
Co-authored-by: Chris Negus <[email protected]>
Co-authored-by: Chris Negus <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the updates. Some minor modifications.
Co-authored-by: Chris Doherty <[email protected]>
since now it supports apple and arm processor.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7067 +/- ##
==========================================
+ Coverage 71.35% 71.56% +0.20%
==========================================
Files 544 545 +1
Lines 41966 42318 +352
==========================================
+ Hits 29943 30283 +340
+ Misses 10345 10343 -2
- Partials 1678 1692 +14 ☔ View full report in Codecov by Sentry. |
/cherry-pick release-0.18 |
@chrisnegus: once the present PR merges, I will cherry-pick it on top of release-0.18 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@chrisnegus: new pull request created: #7153 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This fix the docs to show that eks now supports apple and arm processor.
related issue #182