Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add implementation for NodeUpgradeController #7061

Merged
merged 9 commits into from
Nov 23, 2023

resolve comments

b691d5e
Select commit
Loading
Failed to load commit list.
Merged

Add implementation for NodeUpgradeController #7061

resolve comments
b691d5e
Select commit
Loading
Failed to load commit list.
Codecov / codecov/patch succeeded Nov 23, 2023 in 0s

80.66% of diff hit (target 80.00%)

View this Pull Request on Codecov

80.66% of diff hit (target 80.00%)

Annotations

Check warning on line 62 in controllers/nodeupgrade_controller.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

controllers/nodeupgrade_controller.go#L59-L62

Added lines #L59 - L62 were not covered by tests

Check warning on line 85 in controllers/nodeupgrade_controller.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

controllers/nodeupgrade_controller.go#L82-L85

Added lines #L82 - L85 were not covered by tests

Check warning on line 91 in controllers/nodeupgrade_controller.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

controllers/nodeupgrade_controller.go#L90-L91

Added lines #L90 - L91 were not covered by tests

Check warning on line 96 in controllers/nodeupgrade_controller.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

controllers/nodeupgrade_controller.go#L95-L96

Added lines #L95 - L96 were not covered by tests

Check warning on line 100 in controllers/nodeupgrade_controller.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

controllers/nodeupgrade_controller.go#L99-L100

Added lines #L99 - L100 were not covered by tests

Check warning on line 106 in controllers/nodeupgrade_controller.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

controllers/nodeupgrade_controller.go#L105-L106

Added lines #L105 - L106 were not covered by tests

Check warning on line 112 in controllers/nodeupgrade_controller.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

controllers/nodeupgrade_controller.go#L111-L112

Added lines #L111 - L112 were not covered by tests

Check warning on line 127 in controllers/nodeupgrade_controller.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

controllers/nodeupgrade_controller.go#L126-L127

Added lines #L126 - L127 were not covered by tests

Check warning on line 152 in controllers/nodeupgrade_controller.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

controllers/nodeupgrade_controller.go#L151-L152

Added lines #L151 - L152 were not covered by tests

Check warning on line 158 in controllers/nodeupgrade_controller.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

controllers/nodeupgrade_controller.go#L156-L158

Added lines #L156 - L158 were not covered by tests

Check warning on line 162 in controllers/nodeupgrade_controller.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

controllers/nodeupgrade_controller.go#L161-L162

Added lines #L161 - L162 were not covered by tests

Check warning on line 183 in controllers/nodeupgrade_controller.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

controllers/nodeupgrade_controller.go#L182-L183

Added lines #L182 - L183 were not covered by tests

Check warning on line 204 in controllers/nodeupgrade_controller.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

controllers/nodeupgrade_controller.go#L200-L204

Added lines #L200 - L204 were not covered by tests

Check warning on line 218 in controllers/nodeupgrade_controller.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

controllers/nodeupgrade_controller.go#L217-L218

Added lines #L217 - L218 were not covered by tests

Check warning on line 225 in controllers/nodeupgrade_controller.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

controllers/nodeupgrade_controller.go#L224-L225

Added lines #L224 - L225 were not covered by tests

Check warning on line 250 in controllers/nodeupgrade_controller.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

controllers/nodeupgrade_controller.go#L245-L250

Added lines #L245 - L250 were not covered by tests

Check warning on line 347 in controllers/nodeupgrade_controller.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

controllers/nodeupgrade_controller.go#L341-L347

Added lines #L341 - L347 were not covered by tests

Check warning on line 89 in pkg/api/v1alpha1/nodeupgrade_types.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

pkg/api/v1alpha1/nodeupgrade_types.go#L88-L89

Added lines #L88 - L89 were not covered by tests

Check warning on line 94 in pkg/api/v1alpha1/nodeupgrade_types.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

pkg/api/v1alpha1/nodeupgrade_types.go#L93-L94

Added lines #L93 - L94 were not covered by tests