Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tinkerbell e2e env #6792

Merged
merged 1 commit into from
Oct 10, 2023
Merged

Conversation

tatlat
Copy link
Member

@tatlat tatlat commented Oct 10, 2023

Issue #, if available:

Description of changes:

Testing (if applicable):

Documentation added/planned (if applicable):

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@eks-distro-bot eks-distro-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 10, 2023
@tatlat tatlat force-pushed the update-tinkerbell-e2e branch from 41700e6 to e88ed02 Compare October 10, 2023 16:47
@tatlat
Copy link
Member Author

tatlat commented Oct 10, 2023

/approve

@codecov
Copy link

codecov bot commented Oct 10, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (6885c2d) 71.75% compared to head (e88ed02) 71.75%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6792   +/-   ##
=======================================
  Coverage   71.75%   71.75%           
=======================================
  Files         531      531           
  Lines       41248    41248           
=======================================
  Hits        29597    29597           
  Misses       9993     9993           
  Partials     1658     1658           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@abhay-krishna abhay-krishna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhay-krishna, tatlat

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [abhay-krishna,tatlat]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@eks-distro-bot eks-distro-bot merged commit eea5f5f into aws:main Oct 10, 2023
5 checks passed
ahreehong pushed a commit to ahreehong/eks-anywhere that referenced this pull request Oct 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants