Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dev bundle for K8s version 1.31 #1158

Merged
merged 2 commits into from
Sep 8, 2024

Conversation

sp1999
Copy link
Member

@sp1999 sp1999 commented Sep 7, 2024

Issue #, if available:
#2399

Description of changes:
Add dev bundles for K8s version 1.31
Exclude G115 from Gosec Security Scanner as it was failing with following error:

[/github/workspace/cmd/root.go:34] - G115 (CWE-190): integer overflow conversion int -> int8 (Confidence: MEDIUM, Severity: HIGH)
    33: 	cfg := zap.NewDevelopmentConfig()
  > 34: 	cfg.Level = zap.NewAtomicLevelAt(zapcore.Level(-1 * level))
    35: 	cfg.EncoderConfig.EncodeLevel = nil

Ref:- moby/moby#48358 (comment)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@eks-distro-bot eks-distro-bot added approved size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 7, 2024
@abhay-krishna
Copy link
Member

/lgtm
/approve

@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhay-krishna, sp1999

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [abhay-krishna,sp1999]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@eks-distro-bot eks-distro-bot merged commit 5c0dbc3 into aws:main Sep 8, 2024
6 checks passed
@sp1999 sp1999 deleted the add-1.31-dev-bundle branch October 4, 2024 00:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants