Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More tests need to be added in test directory.
Code-coverage info is in the web pages in the CODE_COVERAGE directory.
Instructions:
cmake ../ -DCODE_COVERAGE=ON
make -j
./credentials-fetcher-test
cd CMakeFiles/credentials-fetcher-test.dir/test
ls *.gcno
gcov tester.cpp.gcno
lcov --capture --directory . --output-file gtest_coverage.info --ignore-errors mismatch
genhtml gtest_coverage.info --output-directory CODE_COVERAGE
Logs:
$ ./credentials-fetcher-test
Running main() from /builddir/build/BUILD/googletest-release-1.11.0/googletest/src/gtest_main.cc
[==========] Running 1 test from 1 test suite.
[----------] Global test environment set-up.
[----------] 1 test from DaemonTest
[ RUN ] DaemonTest.InvalidCharacterTest
[ OK ] DaemonTest.InvalidCharacterTest (0 ms)
[----------] 1 test from DaemonTest (0 ms total)
Issue #, if available:
Description of changes:
Testing done:
Merge Checklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.General
Tests
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.