Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#648
Description of changes:
Implementation:
args[0]
in fetch_p.js, line 74 could be any stringifyable object, not just a string. That object should be converted to a string and used as URL. The only exception to this is ifargs[0]
is already a request object.This PR assumes that such a request object must be from the same implementation as the one given by requestClass. So if you would put a one Request object from e.g. node-fetch into the native fetch implementation, this will stringify that request object.
I couldn't find any "official" way to distinguish between a request object and a stringifyable object. But you're supposed to call fetch with the corresponding request implementation, I think this is fair game.
For that reason, the test was changed, so it will provide the native Request object.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.