Pass dispatcher options to global fetch #653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jj22ee
reviewed
Jul 1, 2024
|
The tests are failing on NodeJS v20.x. Can you take a look into them, perhaps my suggestion could fix them? |
|
Hey sorry for the late update! I did not get a notification that the tests ran here. |
jj22ee
approved these changes
Jul 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
*Issue: #650
Description of changes:
As the global fetch in node follows the undici fetch implementation there is an extra dispatcher option that can be passed but is not supported by the Request class.
We check if the extra option is supplied and if so pass the option directly to the global fetch call. All other paths already pass all options as expected.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.