SharedConfigState (work in progress) #86
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#74 use of a credential profile
Description of changes:
I'm loading the AWS Region based on the region set in the local profile. The summary of key changes are:
getDefaultSession
now enables theSharedConfigState
option.noMetadata
is set totrue
, we load the region fromSession.Config.Region
I've gone through a few iterations attempting to find the best place to put this check and I'm not sure I have it where it should go.
It does work for me locally but I'm not 100% sure it won't interfere with other use cases. I haven't been able to completely follow the EC2 metadata flows.
While I have confirmed that my traces are being published as expected (using my profile and that profile's region), I do get a context canceled error like:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.