Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SharedConfigState (work in progress) #86

Merged
merged 4 commits into from
Dec 29, 2020
Merged

SharedConfigState (work in progress) #86

merged 4 commits into from
Dec 29, 2020

Conversation

mousedownmike
Copy link
Contributor

Issue #, if available:

#74 use of a credential profile

Description of changes:

I'm loading the AWS Region based on the region set in the local profile. The summary of key changes are:

  • getDefaultSession now enables the SharedConfigState option.
  • if noMetadata is set to true, we load the region from Session.Config.Region

I've gone through a few iterations attempting to find the best place to put this check and I'm not sure I have it where it should go.
It does work for me locally but I'm not 100% sure it won't interfere with other use cases. I haven't been able to completely follow the EC2 metadata flows.

While I have confirmed that my traces are being published as expected (using my profile and that profile's region), I do get a context canceled error like:

2020-12-12T10:20:11-08:00 [Debug] Received request on HTTP Proxy server : /GetSamplingRules
2020/12/12 10:20:18 http: proxy error: context canceled

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@srprash srprash requested a review from wangzlei December 15, 2020 01:01
@wangzlei
Copy link
Contributor

@mousedownmike Kindly ask, this PR still work in progress?

@mousedownmike
Copy link
Contributor Author

Hi @wangzlei I marked it as a "work in progress" to indicate it works for my use case but I'm not sure what the other use cases are. If it works where you expect it to, it should be good.

@wangzlei wangzlei merged commit 7494caf into aws:master Dec 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants